Skip to content

Bump ruby to 2.7.5#33485

Closed
danilobuerger wants to merge 3 commits into
react:mainfrom
danilobuerger:ruby275
Closed

Bump ruby to 2.7.5#33485
danilobuerger wants to merge 3 commits into
react:mainfrom
danilobuerger:ruby275

Conversation

@danilobuerger

@danilobuerger danilobuerger commented Mar 24, 2022

Copy link
Copy Markdown
Contributor

Summary

This bumps ruby to the latest 2.7.x versions which includes bug fixes and 3 CVEs (https://www.ruby-lang.org/en/news/2021/11/24/ruby-2-7-5-released/)

Changelog

[iOS] [Changed] - Bump ruby to 2.7.5

Test Plan

no test plan, should just pass tests.

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Mar 24, 2022
@react-native-bot react-native-bot added the Platform: iOS iOS applications. label Mar 24, 2022
@danilobuerger danilobuerger requested a review from hramos as a code owner March 24, 2022 09:01
@analysis-bot

analysis-bot commented Mar 24, 2022 •
edited
Loading

Copy link
Copy Markdown
Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,810,215 +0
android hermes armeabi-v7a 7,201,815 +0
android hermes x86 8,118,845 +0
android hermes x86_64 8,098,971 +0
android jsc arm64-v8a 9,643,725 +0
android jsc armeabi-v7a 8,417,974 +0
android jsc x86 9,592,917 +0
android jsc x86_64 10,190,102 +0

Base commit: 184dfb8
Branch: main

@facebook-github-bot

facebook-github-bot commented Mar 24, 2022

Copy link
Copy Markdown
Contributor

@GijsWeterings has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

cortinico
cortinico reviewed Mar 24, 2022
View reviewed changes

@cortinico cortinico left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good but I would hold-on on this till master is green again. @hramos is already aware of it and is looking into it.

Just want to make sure we don't break things even further

Comment thread .circleci/config.yml Outdated
@danilobuerger danilobuerger force-pushed the ruby275 branch 2 times, most recently from 7a83c17 to 6482b58 Compare March 25, 2022 12:00
@analysis-bot

analysis-bot commented Mar 25, 2022 •
edited
Loading

Copy link
Copy Markdown
Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 184dfb8
Branch: main

cortinico
cortinico approved these changes Mar 25, 2022
View reviewed changes

@cortinico cortinico left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This time the CI failure is a flaky test so we should be good to go

@facebook-github-bot

facebook-github-bot commented Apr 1, 2022

Copy link
Copy Markdown
Contributor

@GijsWeterings has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@danilobuerger

danilobuerger commented Apr 3, 2022

Copy link
Copy Markdown
Contributor Author

@cortinico as @mikehardy mentioned in reactwg/react-native-releases#19 (reply in thread) it might be worthwhile to bump straight to the newest version of ruby instead of just the newest in the 2.7 release. What do you think? Are there any internal reasons to stay on 2.7?

@kelset

kelset commented Apr 4, 2022

Copy link
Copy Markdown
Contributor

I'm trying to learn if from the MSFT side of things we have some specific requirements about Ruby (for now, I couldn't find anything), but in the meantime I'm looking at the Ruby website:

But I'm still asking around MSFT internally to learn if there's any reason why we might want to stay on 2.7 so take what I'm saying with a pinch of salt

@cortinico

cortinico commented Apr 4, 2022

Copy link
Copy Markdown
Contributor

@cortinico as @mikehardy mentioned in reactwg/react-native-releases#19 (reply in thread) it might be worthwhile to bump straight to the newest version of ruby instead of just the newest in the 2.7 release. What do you think? Are there any internal reasons to stay on 2.7?

I don't see any blockers on top of my mind. I believe we're good to go, as long as it concerns the iOS build pipeline. I would however suggest we:

  1. Merge this PR first.
  2. Do the bump to Ruby 3 in a separate PR as see if things are breaking because of that.

The reason is that it might not make it into 0.69.x and I believe we can anyway land this PR regardless 👍

@danilobuerger

danilobuerger commented Apr 4, 2022

Copy link
Copy Markdown
Contributor Author

@cortinico Thanks for the feedback. Sounds like a plan.

@react-native-bot

react-native-bot commented Apr 12, 2022

Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @danilobuerger in 2c87b74.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Apr 12, 2022
@cortinico cortinico mentioned this pull request Apr 14, 2022
Closed
amgleitman added a commit to amgleitman/react-native-macos that referenced this pull request May 17, 2022
@amgleitman
Bump ruby to 2.7.5 (react#33485)
9ee60fa 
Summary:
This bumps ruby to the latest 2.7.x versions which includes bug fixes and 3 CVEs (https://www.ruby-lang.org/en/news/2021/11/24/ruby-2-7-5-released/)

[iOS] [Changed] - Bump ruby to 2.7.5

Pull Request resolved: react#33485

Test Plan: no test plan, should just pass tests.

Reviewed By: cortinico

Differential Revision: D35116757

Pulled By: GijsWeterings

fbshipit-source-id: a8e96bfcc6086b70dac21aee24bae46fe6b072bb
@amgleitman amgleitman mentioned this pull request May 17, 2022
Merged
amgleitman added a commit to microsoft/react-native-macos that referenced this pull request May 19, 2022
@amgleitman
Merge pull request #1172 from amgleitman/use-ruby-2.7.5
b0ce1f3 
Bump ruby to 2.7.5 (react#33485)
douglowder pushed a commit to react-native-tvos/react-native-tvos that referenced this pull request Jan 2, 2023
@danilobuerger @douglowder
Bump ruby to 2.7.5 (#33485)
596114c 
Summary:
This bumps ruby to the latest 2.7.x versions which includes bug fixes and 3 CVEs (https://www.ruby-lang.org/en/news/2021/11/24/ruby-2-7-5-released/)

Edit: Bumping to 2.7.7 which is the latest today.

[iOS] [Changed] - Bump ruby to 2.7.5

Pull Request resolved: react/react-native#33485

Test Plan: no test plan, should just pass tests.

Reviewed By: cortinico

Differential Revision: D35116757

Pulled By: GijsWeterings

fbshipit-source-id: a8e96bfcc6086b70dac21aee24bae46fe6b072bb
Saadnajmi pushed a commit to Saadnajmi/react-native-macos that referenced this pull request Jan 15, 2023
@danilobuerger @Saadnajmi
Bump ruby to 2.7.5 (react#33485)
2da10ba 
Summary:
This bumps ruby to the latest 2.7.x versions which includes bug fixes and 3 CVEs (https://www.ruby-lang.org/en/news/2021/11/24/ruby-2-7-5-released/)

[iOS] [Changed] - Bump ruby to 2.7.5

Pull Request resolved: react#33485

Test Plan: no test plan, should just pass tests.

Reviewed By: cortinico

Differential Revision: D35116757

Pulled By: GijsWeterings

fbshipit-source-id: a8e96bfcc6086b70dac21aee24bae46fe6b072bb
@dcangulo dcangulo mentioned this pull request Feb 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cortinico cortinico cortinico approved these changes

@hramos hramos Awaiting requested review from hramos

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Platform: iOS iOS applications. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@danilobuerger @analysis-bot @facebook-github-bot @kelset @cortinico @react-native-bot